Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal in the editor area has decorations clipped #145044

Closed
meganrogge opened this issue Mar 14, 2022 · 3 comments · Fixed by #145054
Closed

Terminal in the editor area has decorations clipped #145044

meganrogge opened this issue Mar 14, 2022 · 3 comments · Fixed by #145054
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Milestone
March 2022

Comments

@meganrogge
Copy link
Contributor

Screen Shot 2022-03-14 at 10 35 59 AM
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration, command decorations, etc. labels Mar 14, 2022
@meganrogge meganrogge added this to the March 2022 milestone Mar 14, 2022
@meganrogge
Copy link
Contributor Author

fixed by setting a margin-left of 10px, but then the scrollbar is partially obscured

@meganrogge
Copy link
Contributor Author

$('.integrated-terminal.shell-integration .xterm') has left padding of 20px applied which seems to make the difference. That element doesn't exist when the terminal is in the editor area
Screen Shot 2022-03-14 at 10 43 40 AM

@Tyriar
Copy link
Member

Tyriar commented Mar 14, 2022

Let's add a selector to the 20px rule for .monaco-workbench .editor-instance .xterm

meganrogge added a commit that referenced this issue Mar 14, 2022
@meganrogge
fix #145044
fa5b798
@meganrogge meganrogge mentioned this issue Mar 14, 2022
Merged
meganrogge added a commit that referenced this issue Mar 14, 2022
@meganrogge
fix #145044 (#145054)
5a751e2
@rzhao271 rzhao271 added the verified Verification succeeded label Mar 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc. verified Verification succeeded
Projects
None yet
Milestone
March 2022
Development

Successfully merging a pull request may close this issue.

set left padding on terminal in the editor area microsoft/vscode
4 participants
@Tyriar @rzhao271 @meganrogge and others