Action in explorer is interrupted shortly after creating a folder

[Tyriar]

Repro 1:

• Create a folder
• Try rename it

Repro 2:

• Create a folder
• Try create a file

---

Version: 1.52.0-insider (user setup)
Commit: bf21395
Date: 2020-12-01T09:19:32.000Z
Electron: 9.3.5
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19042

[isidorn]

This works fine for me.
Though I do acknowledge that there might be a timing issue here, I just do not see it on my mac. Not a recent regression -> assigning to December to investigate more then.

[Tyriar]

I can't reproduce in 1.51.1 with --disable-extensions. Note that I don't have any settings on either and it happens on Insiders only. Here's the keybinding I was using in the gif, but it happens when clicking the new folder button as well, just be quick with F2:

{ "key": "ctrl+shift+n",     "command": "explorer.newFolder", "when": "explorerViewletVisible && filesExplorerFocus && !isMac" },

Tested and works fine in:

Version: 1.51.1 (user setup)
Commit: e5a624b
Date: 2020-11-10T23:34:32.027Z
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19042

[isidorn]

Ok I can finally repro if I do it very fast.
@jeanp413 fyi if you might be interested in a PR since I know you touched this area a couple of times

[jeanp413]

Sure I'll take a look

[jeanp413]

@isidorn the commit that caused the regression is c8d123d
The difference is that now we are refreshing the explorer even though the added resource is already part of the explorer model.
I saw you commited some optimizations in 564ff91 but to fix this we need a way to avoid refreshing unnecessarily in this specific case

[isidorn]

@jeanp413 that is very useful. Thanks for investigating. I know how to fix, but would prefer to fix in debt week as it is last day of the endgame. Thus let's leave this for December and I will fix next week - I will aggressivly change how we react on file events and not refresh in the case when the resource is already part of the explorer model.

[isidorn]

@Tyriar @joaomoreno thanks a lot for filling this
We should be good with my fix

[isidorn]

Also let me know if you see some file events missing or any file event funkiness in Insiders

[Tyriar]

Haven't seen this in quite a while, thanks for the fix!

[isidorn]

Thank you for reporting!