column options in openWith-command can be undefined, fyi @mjbvz

microsoft · Dec 1, 2020 · bf21395 · bf21395
1 parent 3472159
commit bf21395
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/vs/workbench/browser/parts/editor/editorCommands.ts b/src/vs/workbench/browser/parts/editor/editorCommands.ts
@@ -480,13 +480,13 @@ function registerOpenEditorAPICommands(): void {
  }, viewColumnToEditorGroup(editorGroupService, column));
  });
 
- CommandsRegistry.registerCommand(API_OPEN_WITH_EDITOR_COMMAND_ID, (accessor: ServicesAccessor, resource: UriComponents, id: string, columnAndOptions: [EditorGroupColumn?, ITextEditorOptions?]) => {
+ CommandsRegistry.registerCommand(API_OPEN_WITH_EDITOR_COMMAND_ID, (accessor: ServicesAccessor, resource: UriComponents, id: string, columnAndOptions?: [EditorGroupColumn?, ITextEditorOptions?]) => {
  const editorService = accessor.get(IEditorService);
  const editorGroupsService = accessor.get(IEditorGroupsService);
  const configurationService = accessor.get(IConfigurationService);
  const quickInputService = accessor.get(IQuickInputService);
 
- const [columnArg, optionsArg] = columnAndOptions;
+ const [columnArg, optionsArg] = columnAndOptions ?? [];
  let group: IEditorGroup | undefined = undefined;
 
  if (columnArg === SIDE_GROUP) {