Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two full TS servers spawned for on TS 3.9.x #104456

Closed
mjbvz opened this issue Aug 11, 2020 · 4 comments
Closed

Two full TS servers spawned for on TS 3.9.x #104456

mjbvz opened this issue Aug 11, 2020 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Aug 11, 2020

Issue Type: Bug

repo

  1. npm i -g [email protected]

  2. Set your user tsdk to use this version, for example:

    	"typescript.tsdk": "/Users/matb/.nvm/versions/node/v12.14.0/lib/node_modules/typescript/lib"
    
  3. Now load the VS Code workspace (making sure you are using your user TS version)

  4. Open a file in src and try getting the document outline

Bug
Big delay.

This is because two full TS Servers are being spawned instead of a syntax only server + full server (see memory usage in screenshot):

Screen Shot 2020-08-11 at 3 13 33 PM

VS Code version: Code - Insiders 1.48.0-insider (4c23fc2, 2020-08-11T10:13:04.551Z)
OS version: Darwin x64 19.6.0

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) 6, 6, 5
Memory (System) 32.00GB (3.02GB free)
Process Argv -psn_0_42174518
Screen Reader no
VM 14%
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Aug 11, 2020
@mjbvz mjbvz added this to the August 2020 milestone Aug 11, 2020
@mjbvz mjbvz self-assigned this Aug 11, 2020
@mjbvz
Copy link
Collaborator Author

mjbvz commented Aug 11, 2020

Seems like this was caused by #104123

@mjbvz
Copy link
Collaborator Author

mjbvz commented Aug 11, 2020

For verification, try the following cases:

  • Using TS 3.9.7
  • Using TS 4.0.1-rc
  • Using TS@next
  • Using an old TS version like 3.5 (older versions don't support the syntax server at all)

All should load the document symbols quickly even while the loading spinner is showing

You can use the same global install in all cases, just make sure to reload VS Code each time

@isidorn
Copy link
Contributor

isidorn commented Aug 12, 2020

Assigning this to july milestone since it is a candidate.

@isidorn isidorn modified the milestones: August 2020, July 2020 Aug 12, 2020
@isidorn
Copy link
Contributor

isidorn commented Aug 13, 2020

@mjbvz following your steps I have verified that the outline get loaded quickly, however I still see two tsservers spinning up when I open the process explorer. If I understood correctly this is by design, since only one of them has a large memory usage.
I have verified for TS: 3.9.7, 4.0.1-rc. ts@next, 3.5
Thus adding verified label

Screenshot 2020-08-13 at 12 30 55

@isidorn isidorn added the verified Verification succeeded label Aug 13, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants
@isidorn @mjbvz and others