Skip to content

Commit

Permalink
Disable web TS type acquisition (#213412)
Browse files Browse the repository at this point in the history
We're waiting on some perf improvement for upstream types installer before turning this on everywhere
  • Loading branch information
mjbvz committed May 24, 2024
1 parent d05d280 commit fb7f5a9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions extensions/typescript-language-features/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -1284,13 +1284,13 @@
},
"typescript.tsserver.web.projectWideIntellisense.suppressSemanticErrors": {
"type": "boolean",
"default": false,
"default": true,
"description": "%configuration.tsserver.web.projectWideIntellisense.suppressSemanticErrors%",
"scope": "window"
},
"typescript.tsserver.web.typeAcquisition.enabled": {
"type": "boolean",
"default": true,
"default": false,
"description": "%configuration.tsserver.web.typeAcquisition.enabled%",
"scope": "window"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -261,10 +261,10 @@ export abstract class BaseServiceConfigurationProvider implements ServiceConfigu
}

private readWebProjectWideIntellisenseSuppressSemanticErrors(configuration: vscode.WorkspaceConfiguration): boolean {
return configuration.get<boolean>('typescript.tsserver.web.projectWideIntellisense.suppressSemanticErrors', false);
return configuration.get<boolean>('typescript.tsserver.web.projectWideIntellisense.suppressSemanticErrors', true);
}

private readWebTypeAcquisition(configuration: vscode.WorkspaceConfiguration): boolean {
return configuration.get<boolean>('typescript.tsserver.web.typeAcquisition.enabled', true);
return configuration.get<boolean>('typescript.tsserver.web.typeAcquisition.enabled', false);
}
}

0 comments on commit fb7f5a9

Please sign in to comment.