Remove unused method getAllRecommendations()

microsoft · Nov 16, 2018 · cb1c3ed · cb1c3ed
1 parent f8a46bc
commit cb1c3ed
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 13 deletions.
diff --git a/src/vs/platform/extensionManagement/common/extensionManagement.ts b/src/vs/platform/extensionManagement/common/extensionManagement.ts
@@ -426,7 +426,6 @@ export interface IExtensionTipsService {
  getOtherRecommendations(): Promise<IExtensionRecommendation[]>;
  getWorkspaceRecommendations(): Promise<IExtensionRecommendation[]>;
  getKeymapRecommendations(): IExtensionRecommendation[];
- getAllRecommendations(): Promise<IExtensionRecommendation[]>;
  getKeywordsForExtension(extension: string): string[];
  toggleIgnoredRecommendation(extensionId: string, shouldIgnore: boolean): void;
  getAllIgnoredRecommendations(): { global: string[], workspace: string[] };

diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionTipsService.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionTipsService.ts
@@ -421,18 +421,6 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe
  .map(extensionId => (<IExtensionRecommendation>{ extensionId, sources: ['application'] }));
  }
 
- getAllRecommendations(): Promise<IExtensionRecommendation[]> {
- if (!this.proactiveRecommendationsFetched) {
- return Promise.resolve([]);
- }
- return Promise.all([
- this.getWorkspaceRecommendations(),
- Promise.resolve(this.getFileBasedRecommendations()),
- this.getOtherRecommendations(),
- Promise.resolve(this.getKeymapRecommendations())
- ]).then(result => flatten(result).filter(e => this.isExtensionAllowedToBeRecommended(e.extensionId)));
- }
-
  private fetchFileBasedRecommendations() {
  const extensionTips = product.extensionTips;
  if (!extensionTips) {