Remove custom editor tests (#152777)

These tests are not actively being run or maintained. Removing them for now

.vscode/launch.json

@@ -201,24 +201,6 @@
  "order": 5
  }
  },
- {
- "type": "extensionHost",
- "request": "launch",
- "name": "VS Code Custom Editor Tests",
- "runtimeExecutable": "${execPath}",
- "args": [
- "${workspaceFolder}/extensions/vscode-custom-editor-tests/test-workspace",
- "--extensionDevelopmentPath=${workspaceFolder}/extensions/vscode-custom-editor-tests",
- "--extensionTestsPath=${workspaceFolder}/extensions/vscode-custom-editor-tests/out/test"
- ],
- "outFiles": [
- "${workspaceFolder}/out/**/*.js"
- ],
- "presentation": {
- "group": "5_tests",
- "order": 6
- }
- },
  {
  "type": "pwa-chrome",
  "request": "attach",

build/azure-pipelines/darwin/product-build-darwin-test.yml

@@ -52,7 +52,6 @@ steps:
  compile-extension:typescript-language-features \
  compile-extension:vscode-api-tests \
  compile-extension:vscode-colorize-tests \
- compile-extension:vscode-custom-editor-tests \
  compile-extension:vscode-notebook-tests \
  compile-extension:vscode-test-resolver
  displayName: Build integration tests

build/azure-pipelines/linux/product-build-linux-client-test.yml

@@ -64,7 +64,6 @@ steps:
  compile-extension:typescript-language-features \
  compile-extension:vscode-api-tests \
  compile-extension:vscode-colorize-tests \
- compile-extension:vscode-custom-editor-tests \
  compile-extension:vscode-notebook-tests \
  compile-extension:vscode-test-resolver
  displayName: Build integration tests

build/azure-pipelines/win32/product-build-win32-test.yml

@@ -58,7 +58,6 @@ steps:
  compile-extension:typescript-language-features `
  compile-extension:vscode-api-tests `
  compile-extension:vscode-colorize-tests `
- compile-extension:vscode-custom-editor-tests `
  compile-extension:vscode-notebook-tests `
  compile-extension:vscode-test-resolver `
  }

build/filters.js

@@ -48,7 +48,6 @@ module.exports.unicodeFilter = [
  '!extensions/typescript-language-features/test-workspace/**',
  '!extensions/vscode-api-tests/testWorkspace/**',
  '!extensions/vscode-api-tests/testWorkspace2/**',
- '!extensions/vscode-custom-editor-tests/test-workspace/**',
  '!extensions/**/dist/**',
  '!extensions/**/out/**',
  '!extensions/**/snippets/**',
@@ -84,7 +83,6 @@ module.exports.indentationFilter = [
  '!extensions/markdown-math/notebook-out/**',
  '!extensions/vscode-api-tests/testWorkspace/**',
  '!extensions/vscode-api-tests/testWorkspace2/**',
- '!extensions/vscode-custom-editor-tests/test-workspace/**',
  '!build/monaco/**',
  '!build/win32/**',
 

build/gulpfile.extensions.js

@@ -66,7 +66,6 @@ const compilations = [
  'typescript-language-features/tsconfig.json',
  'vscode-api-tests/tsconfig.json',
  'vscode-colorize-tests/tsconfig.json',
- 'vscode-custom-editor-tests/tsconfig.json',
  'vscode-notebook-tests/tsconfig.json',
  'vscode-test-resolver/tsconfig.json'
 ];

build/lib/extensions.js

@@ -246,7 +246,6 @@ const excludedExtensions = [
  'ms-vscode.node-debug',
  'ms-vscode.node-debug2',
  'vscode-notebook-tests',
- 'vscode-custom-editor-tests',
 ];
 const marketplaceWebExtensionsExclude = new Set([
  'ms-vscode.node-debug',

build/lib/extensions.ts

@@ -286,7 +286,6 @@ const excludedExtensions = [
  'ms-vscode.node-debug',
  'ms-vscode.node-debug2',
  'vscode-notebook-tests',
- 'vscode-custom-editor-tests',
 ];
 
 const marketplaceWebExtensionsExclude = new Set([

build/npm/dirs.js

@@ -41,7 +41,6 @@ exports.dirs = [
  'extensions/typescript-language-features',
  'extensions/vscode-api-tests',
  'extensions/vscode-colorize-tests',
- 'extensions/vscode-custom-editor-tests',
  'extensions/vscode-notebook-tests',
  'extensions/vscode-test-resolver',
  'remote',

extensions/markdown-language-features/src/extension.ts

@@ -38,8 +38,10 @@ export function activate(context: vscode.ExtensionContext) {
  const contributions = getMarkdownExtensionContributions(context);
  context.subscriptions.push(contributions);
 
- const cspArbiter = new ExtensionContentSecurityPolicyArbiter(context.globalState, context.workspaceState);
  const logger = new Logger();
+ context.subscriptions.push(logger);
+
+ const cspArbiter = new ExtensionContentSecurityPolicyArbiter(context.globalState, context.workspaceState);
  const commandManager = new CommandManager();
 
  const engine = new MarkdownItEngine(contributions, githubSlugifier);
@@ -56,7 +58,6 @@ export function activate(context: vscode.ExtensionContext) {
  context.subscriptions.push(registerMarkdownCommands(commandManager, previewManager, telemetryReporter, cspArbiter, engine, tocProvider));
 
  context.subscriptions.push(vscode.workspace.onDidChangeConfiguration(() => {
- logger.updateConfiguration();
  previewManager.updateConfiguration();
  }));
 }

extensions/markdown-language-features/src/logger.ts

@@ -4,6 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import * as vscode from 'vscode';
+import { Disposable } from './util/dispose';
 import { lazy } from './util/lazy';
 
 enum Trace {
@@ -25,17 +26,18 @@ namespace Trace {
  }
 }
 
-
-function isString(value: any): value is string {
- return Object.prototype.toString.call(value) === '[object String]';
-}
-
-export class Logger {
+export class Logger extends Disposable {
  private trace?: Trace;
 
- private readonly outputChannel = lazy(() => vscode.window.createOutputChannel('Markdown'));
+ private readonly outputChannel = lazy(() => this._register(vscode.window.createOutputChannel('Markdown')));
 
  constructor() {
+ super();
+
+ this._register(vscode.workspace.onDidChangeConfiguration(() => {
+ this.updateConfiguration();
+ }));
+
  this.updateConfiguration();
  }
 
@@ -48,20 +50,19 @@ export class Logger {
  }
  }
 
-
  private now(): string {
  const now = new Date();
  return String(now.getUTCHours()).padStart(2, '0')
  + ':' + String(now.getMinutes()).padStart(2, '0')
  + ':' + String(now.getUTCSeconds()).padStart(2, '0') + '.' + now.getMilliseconds();
  }
 
- public updateConfiguration() {
+ private updateConfiguration(): void {
  this.trace = this.readTrace();
  }
 
- private appendLine(value: string) {
- return this.outputChannel.value.appendLine(value);
+ private appendLine(value: string): void {
+ this.outputChannel.value.appendLine(value);
  }
 
  private readTrace(): Trace {
@@ -70,12 +71,12 @@ export class Logger {
 
  private static data2String(data: any): string {
  if (data instanceof Error) {
- if (isString(data.stack)) {
+ if (typeof data.stack === 'string') {
  return data.stack;
  }
- return (data as Error).message;
+ return data.message;
  }
- if (isString(data)) {
+ if (typeof data === 'string') {
  return data;
  }
  return JSON.stringify(data, undefined, 2);