Switching to simple full screen produces a jump (fix #99039)

scripts/code-cli.bat

@@ -30,7 +30,6 @@ if not exist out yarn compile
 set ELECTRON_RUN_AS_NODE=1
 set NODE_ENV=development
 set VSCODE_DEV=1
-REM set ELECTRON_DEFAULT_ERROR_MODE=1 TODO@ben to investigate if this helps with builds reporting stacks if renderer crashes
 set ELECTRON_ENABLE_LOGGING=1
 set ELECTRON_ENABLE_STACK_DUMPING=1
 

scripts/code.bat

@@ -29,7 +29,6 @@ if not exist out yarn compile
 set NODE_ENV=development
 set VSCODE_DEV=1
 set VSCODE_CLI=1
-REM set ELECTRON_DEFAULT_ERROR_MODE=1 TODO@ben to investigate if this helps with builds reporting stacks if renderer crashes
 set ELECTRON_ENABLE_LOGGING=1
 set ELECTRON_ENABLE_STACK_DUMPING=1
 set VSCODE_LOGS=

src/vs/code/electron-main/window.ts

@@ -444,13 +444,27 @@ export class CodeWindow extends Disposable implements ICodeWindow {
  this.setFullScreen(false);
  this.setFullScreen(true);
  }
+ }, 100));
+
+ const displayChangedListener = () => {
 
+ // Fix simple-fullscreen visuals
+ simpleFullScreenScheduler.schedule();
+
+ // Notify renderers
  this.sendWhenReady('vscode:displayChanged');
- }, 100));
+ };
 
- const displayChangedListener = () => simpleFullScreenScheduler.schedule();
+ screen.on('display-metrics-changed', (event, display, changedMetrics) => {
+ if (changedMetrics.length === 1 && changedMetrics[0] === 'workArea') {
+ // Electron will emit 'display-metrics-changed' events even when actually
+ // going fullscreen, because the dock hides. However, we do not want to
+ // react on this event as there is no change in display bounds.
+ return;
+ }
 
- screen.on('display-metrics-changed', displayChangedListener);
+ displayChangedListener();
+ });
  this._register(toDisposable(() => screen.removeListener('display-metrics-changed', displayChangedListener)));
 
  screen.on('display-added', displayChangedListener);

src/vs/workbench/electron-browser/window.ts

@@ -182,6 +182,7 @@ export class NativeWindow extends Disposable {
  this.notificationService.info(message);
  });
 
+ // Display change events
  ipcRenderer.on('vscode:displayChanged', () => {
  clearAllFontInfos();
  });