Kerberos auth for proxies (#188130)

microsoft · Jul 19, 2023 · 6ae441b · 6ae441b
1 parent d1177d5
commit 6ae441b
Show file tree

Hide file tree

Showing 19 changed files with 192 additions and 54 deletions.
diff --git a/.devcontainer/install-vscode.sh b/.devcontainer/install-vscode.sh
@@ -9,4 +9,4 @@ sh -c 'echo "deb [arch=amd64,arm64,armhf signed-by=/etc/apt/keyrings/packages.mi
 rm -f packages.microsoft.gpg
 
 apt update
-apt install -y code-insiders libsecret-1-dev libxkbfile-dev
+apt install -y code-insiders libsecret-1-dev libxkbfile-dev libkrb5-dev
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -107,7 +107,7 @@ jobs:
  - name: Setup Build Environment
  run: |
  sudo apt-get update
- sudo apt-get install -y libxkbfile-dev pkg-config libsecret-1-dev libxss1 dbus xvfb libgtk-3-0 libgbm1
+ sudo apt-get install -y libxkbfile-dev pkg-config libsecret-1-dev libkrb5-dev libxss1 dbus xvfb libgtk-3-0 libgbm1
  sudo cp build/azure-pipelines/linux/xvfb.init /etc/init.d/xvfb
  sudo chmod +x /etc/init.d/xvfb
  sudo update-rc.d xvfb defaults

diff --git a/.github/workflows/monaco-editor.yml b/.github/workflows/monaco-editor.yml
@@ -45,6 +45,9 @@ jobs:
  path: ${{ steps.yarnCacheDirPath.outputs.dir }}
  key: ${{ runner.os }}-yarnCacheDir-${{ steps.nodeModulesCacheKey.outputs.value }}
  restore-keys: ${{ runner.os }}-yarnCacheDir-
+ - name: Install libkrb5-dev
+ if: ${{ steps.cacheNodeModules.outputs.cache-hit != 'true' }}
+ run: sudo apt install -y libkrb5-dev
  - name: Execute yarn
  if: ${{ steps.cacheNodeModules.outputs.cache-hit != 'true' }}
  env:

diff --git a/build/.moduleignore b/build/.moduleignore
@@ -73,6 +73,12 @@ windows-foreground-love/build/**
 windows-foreground-love/src/**
 !windows-foreground-love/**/*.node
 
+kerberos/binding.gyp
+kerberos/build/**
+kerberos/src/**
+kerberos/node_modules/**
+!kerberos/**/*.node
+
 keytar/binding.gyp
 keytar/build/**
 keytar/src/**

diff --git a/build/azure-pipelines/alpine/product-build-alpine.yml b/build/azure-pipelines/alpine/product-build-alpine.yml
@@ -67,6 +67,11 @@ steps:
  displayName: "Pull image"
  condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'))
 
+ - script: |
+ sudo apt-get update && sudo apt-get install -y libkrb5-dev
+ displayName: Install libkrb5-dev
+ condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'))
+
  - script: |
  set -e
  for i in {1..5}; do # try 5 times

diff --git a/build/azure-pipelines/linux/product-build-linux-test.yml b/build/azure-pipelines/linux/product-build-linux-test.yml
@@ -18,7 +18,7 @@ steps:
  - script: |
  set -e
  sudo apt-get update
- sudo apt-get install -y libxkbfile-dev pkg-config libsecret-1-dev libxss1 dbus xvfb libgtk-3-0 libgbm1
+ sudo apt-get install -y libxkbfile-dev pkg-config libsecret-1-dev libkrb5-dev libxss1 dbus xvfb libgtk-3-0 libgbm1
  sudo cp build/azure-pipelines/linux/xvfb.init /etc/init.d/xvfb
  sudo chmod +x /etc/init.d/xvfb
  sudo update-rc.d xvfb defaults

diff --git a/build/azure-pipelines/linux/product-build-linux.yml b/build/azure-pipelines/linux/product-build-linux.yml
@@ -110,6 +110,11 @@ steps:
  displayName: Register Docker QEMU
  condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'), eq(variables['VSCODE_ARCH'], 'arm64'))
 
+ - script: |
+ sudo apt-get update && sudo apt-get install -y libkrb5-dev
+ displayName: Install libkrb5-dev
+ condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'))
+
  - script: |
  set -e
 

diff --git a/build/azure-pipelines/product-compile.yml b/build/azure-pipelines/product-compile.yml
@@ -49,7 +49,7 @@ steps:
  condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'), ne(variables['NPM_REGISTRY'], 'none'))
  displayName: Setup NPM Authentication
 
- - script: sudo apt update -y && sudo apt install -y build-essential pkg-config libx11-dev libx11-xcb-dev libxkbfile-dev libsecret-1-dev libnotify-bin
+ - script: sudo apt update -y && sudo apt install -y build-essential pkg-config libx11-dev libx11-xcb-dev libxkbfile-dev libsecret-1-dev libnotify-bin libkrb5-dev
  displayName: Install build tools
  condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'))
 

diff --git a/build/azure-pipelines/web/product-build-web.yml b/build/azure-pipelines/web/product-build-web.yml
@@ -53,6 +53,11 @@ steps:
  condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'), ne(variables['NPM_REGISTRY'], 'none'))
  displayName: Setup NPM Authentication
 
+ - script: |
+ sudo apt-get update && sudo apt-get install -y libkrb5-dev
+ displayName: Install libkrb5-dev
+ condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'))
+
  - script: |
  set -e
  for i in {1..5}; do # try 5 times

diff --git a/build/linux/debian/dep-lists.js b/build/linux/debian/dep-lists.js
diff --git a/build/linux/debian/dep-lists.ts b/build/linux/debian/dep-lists.ts
@@ -38,8 +38,10 @@ export const referenceGeneratedDepsByArch = {
  'libgbm1 (>= 17.1.0~rc2)',
  'libglib2.0-0 (>= 2.16.0)',
  'libglib2.0-0 (>= 2.39.4)',
+ 'libgssapi-krb5-2 (>= 1.17)',
  'libgtk-3-0 (>= 3.9.10)',
  'libgtk-3-0 (>= 3.9.10) | libgtk-4-1',
+ 'libkrb5-3 (>= 1.6.dfsg.2)',
  'libnspr4 (>= 2:4.9-2~)',
  'libnss3 (>= 2:3.22)',
  'libnss3 (>= 3.26)',
@@ -76,8 +78,10 @@ export const referenceGeneratedDepsByArch = {
  'libgbm1 (>= 17.1.0~rc2)',
  'libglib2.0-0 (>= 2.12.0)',
  'libglib2.0-0 (>= 2.39.4)',
+ 'libgssapi-krb5-2 (>= 1.17)',
  'libgtk-3-0 (>= 3.9.10)',
  'libgtk-3-0 (>= 3.9.10) | libgtk-4-1',
+ 'libkrb5-3 (>= 1.6.dfsg.2)',
  'libnspr4 (>= 2:4.9-2~)',
  'libnss3 (>= 2:3.22)',
  'libnss3 (>= 3.26)',
@@ -113,8 +117,10 @@ export const referenceGeneratedDepsByArch = {
  'libgbm1 (>= 17.1.0~rc2)',
  'libglib2.0-0 (>= 2.12.0)',
  'libglib2.0-0 (>= 2.39.4)',
+ 'libgssapi-krb5-2 (>= 1.17)',
  'libgtk-3-0 (>= 3.9.10)',
  'libgtk-3-0 (>= 3.9.10) | libgtk-4-1',
+ 'libkrb5-3 (>= 1.6.dfsg.2)',
  'libnspr4 (>= 2:4.9-2~)',
  'libnss3 (>= 2:3.22)',
  'libnss3 (>= 3.26)',