ts - enable use code watcher by default (#213450)

microsoft · May 25, 2024 · 2188b46 · 2188b46
1 parent 3e8b60f
commit 2188b46
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 8 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -170,6 +170,5 @@
  },
  "css.format.spaceAroundSelectorSeparator": true,
  "inlineChat.mode": "live",
- "typescript.enablePromptUseWorkspaceTsdk": true,
- "typescript.tsserver.experimental.useVsCodeWatcher": true
+ "typescript.enablePromptUseWorkspaceTsdk": true
 }
diff --git a/extensions/typescript-language-features/package.json b/extensions/typescript-language-features/package.json
@@ -1177,10 +1177,7 @@
  "typescript.tsserver.experimental.useVsCodeWatcher": {
  "type": "boolean",
  "description": "%configuration.tsserver.useVsCodeWatcher%",
- "default": false,
- "tags": [
- "experimental"
- ]
+ "default": true
  },
  "typescript.tsserver.watchOptions": {
  "type": "object",

diff --git a/extensions/typescript-language-features/src/configuration/configuration.ts b/extensions/typescript-language-features/src/configuration/configuration.ts
@@ -117,7 +117,7 @@ export interface TypeScriptServiceConfiguration {
  readonly enableProjectDiagnostics: boolean;
  readonly maxTsServerMemory: number;
  readonly enablePromptUseWorkspaceTsdk: boolean;
- readonly useVsCodeWatcher: boolean;
+ readonly useVsCodeWatcher: boolean; // TODO@bpasero remove this setting eventually
  readonly watchOptions: Proto.WatchOptions | undefined;
  readonly includePackageJsonAutoImports: 'auto' | 'on' | 'off' | undefined;
  readonly enableTsServerTracing: boolean;

diff --git a/src/vs/workbench/contrib/files/browser/workspaceWatcher.ts b/src/vs/workbench/contrib/files/browser/workspaceWatcher.ts
@@ -115,7 +115,8 @@ export class WorkspaceWatcher extends Disposable {
  reason = 'ETERM';
  }
 
- // Log telemetry if we gathered a reason (TODO@bpasero remove me once the TS experiment is over)
+ // Log telemetry if we gathered a reason (logging it from the renderer
+ // allows us to investigate this situation in context of experiments)
  if (reason) {
  type WatchErrorClassification = {
  owner: 'bpasero';