Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Get QuickPick options from fetched matadata #173

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Conversation

CsCherrYY
Copy link
Contributor

In spring initializr steps, will get QuickPick options from fetched matadata, instead of hard coding the options. see #170.

Copy link
Member

@Eskibear Eskibear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'chore' is not proper for this PR. please change it.

src/handler/utils.ts Outdated Show resolved Hide resolved
src/model/ServiceManager.ts Outdated Show resolved Hide resolved
@CsCherrYY
Copy link
Contributor Author

'chore' is not proper for this PR. please change it.

How about feat?

@Eskibear
Copy link
Member

Eskibear commented Mar 8, 2021

rather than a new "feature", it's a "fix" for bug microsoft/vscode-java-pack#547

@CsCherrYY CsCherrYY changed the title chore: Get QuickPick options from fetched matadata fix: Get QuickPick options from fetched matadata Mar 8, 2021
@CsCherrYY CsCherrYY merged commit 7d8cf2e into master Mar 10, 2021
@CsCherrYY CsCherrYY deleted the resolveMetadata branch March 10, 2021 05:12
@CsCherrYY CsCherrYY added this to the 0.7.0 milestone Mar 10, 2021
@CsCherrYY CsCherrYY added the bug label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants