Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show warning and allow user to turn off smart send for deprecated Python code #22353

Merged
merged 31 commits into from
Nov 18, 2023
Merged

Show warning and allow user to turn off smart send for deprecated Python code #22353

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
faebdb6
detect user is on file with deprecated Python code
anthonykim1 Oct 26, 2023
14f9b64
send warning message if smart send deprecated py
anthonykim1 Oct 26, 2023
e1d203f
add setting
anthonykim1 Oct 26, 2023
c5ced54
switch repl and code order to normal
anthonykim1 Oct 26, 2023
bc74433
comply with linting error
anthonykim1 Oct 26, 2023
d0ad1fb
fix for test failing
anthonykim1 Nov 13, 2023
be70c44
comment out unused variables
anthonykim1 Nov 13, 2023
d0fd80d
try adding configService and new REPL setting
anthonykim1 Nov 13, 2023
59805ad
quit unused var warning
anthonykim1 Nov 13, 2023
d911459
add activeResourceService
anthonykim1 Nov 13, 2023
a29ecdd
clean up
anthonykim1 Nov 13, 2023
924f9e8
respect deprecated
anthonykim1 Nov 14, 2023
fe80e93
make a button that leed to change setting
anthonykim1 Nov 14, 2023
e23c504
Change message wording
anthonykim1 Nov 14, 2023
f6f8a4a
Change wording
anthonykim1 Nov 14, 2023
91ffe64
use commandManager rather than calling vs code
anthonykim1 Nov 15, 2023
93ab499
add commandManager
anthonykim1 Nov 15, 2023
972f144
remove systemVariable resolve
anthonykim1 Nov 15, 2023
05d4e7f
add warning message test
anthonykim1 Nov 15, 2023
4ebc502
fix typo
anthonykim1 Nov 16, 2023
9283d80
fix smoke test error
anthonykim1 Nov 16, 2023
4682545
button will actually change setting
anthonykim1 Nov 16, 2023
d3efb7c
Update description according to suggestion
anthonykim1 Nov 16, 2023
f4deb62
add traceInfo message
anthonykim1 Nov 16, 2023
4ba135f
Update src/client/terminals/codeExecution/terminalCodeExecution.ts
anthonykim1 Nov 17, 2023
1794700
touch up on warning message
anthonykim1 Nov 17, 2023
13eeb80
check condition on Disable button
anthonykim1 Nov 17, 2023
4fc0357
Update src/client/terminals/codeExecution/terminalCodeExecution.ts
anthonykim1 Nov 17, 2023
956ee20
put message and button in localize
anthonykim1 Nov 17, 2023
16021ee
lowercase enable
anthonykim1 Nov 18, 2023
7063648
enable for test
anthonykim1 Nov 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
enable for test
  • Loading branch information
@anthonykim1
anthonykim1 committed Nov 18, 2023
commit 7063648146c90f5da10d128fa263a8df5da9d3cd
2 changes: 1 addition & 1 deletion src/test/terminals/codeExecution/smartSend.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ suite('REPL - Smart Send', () => {
.returns(() => activeResourceService.object);
activeResourceService.setup((a) => a.getActiveResource()).returns(() => resource);

pythonSettings.setup((s) => s.REPL).returns(() => ({ EnableREPLSmartSend: true, REPLSmartSend: true }));
pythonSettings.setup((s) => s.REPL).returns(() => ({ enableREPLSmartSend: true, REPLSmartSend: true }));

configurationService.setup((x) => x.getSettings(TypeMoq.It.isAny())).returns(() => pythonSettings.object);

Expand Down
Loading