Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a config provider can't provide a configuration, the base configuration should be used (not the browse configuration) #12144

Closed
Colengms opened this issue Mar 26, 2024 · 3 comments
Assignees
Labels
bug Feature: Configuration Provider Related to the configurationProvider property, e.g. ms-vscode.cmake-tools, ms-vscode.makefile-tools. fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
Milestone

Comments

@Colengms
Copy link
Collaborator

We have a long-standing bug where, when a config provider can't provide a configuration for a file, the browse configuration is used to configure that file instead of the intended behavior of falling back to the base configuration. Opening this issue to track restoring that behavior to using the base configuration.

@Colengms Colengms added bug Language Service Feature: Configuration Provider Related to the configurationProvider property, e.g. ms-vscode.cmake-tools, ms-vscode.makefile-tools. labels Mar 26, 2024
@Colengms Colengms added this to the 1.20.1 milestone Mar 26, 2024
@Colengms Colengms added this to Triage in 1.20 via automation Mar 26, 2024
@Colengms Colengms self-assigned this Mar 26, 2024
@Colengms Colengms moved this from Triage to Pull Request in 1.20 Mar 26, 2024
@Colengms Colengms moved this from Pull Request to Done in 1.20 Mar 26, 2024
@Colengms Colengms added the fixed Check the Milestone for the release in which the fix is or will be available. label Mar 26, 2024
@hamammmm
Copy link

hamammmm commented Apr 1, 2024

#include errors detected. Please update your includePath. Squiggles are disabled for this translation unit (C:\Users\USERWD\Downloads\CMakeFiles\Untitled-1.cpp).C/C++(1696)
cannot open source file "iostream". Please run the 'Select IntelliSense Configuration...' command to locate your system headers.C/C++(1696) [I have this problem]

@Colengms
Copy link
Collaborator Author

Colengms commented Apr 1, 2024

Hi @hamammmm . I don't believe that error message would be related to this issue. Could you open a new issue, and provide the information requested in the new issue template? Given the error message, it would seem your configuration does not have a compiler associated with it, or an attempt to query your selected compiler has failed.

@hamammmm
Copy link

hamammmm commented Apr 15, 2024 via email

@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Feature: Configuration Provider Related to the configurationProvider property, e.g. ms-vscode.cmake-tools, ms-vscode.makefile-tools. fixed Check the Milestone for the release in which the fix is or will be available. Language Service quick fix
Projects
No open projects
1.20
Done
Development

No branches or pull requests

3 participants