Speed up cost of reflection a bit #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides being unused, the PropertyDesc was broken because it pointed at itself.
This also gives MethodRef the ability to represent constructors.
|
@AArnott, |
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 83.06% 82.91% -0.15%
==========================================
Files 72 72
Lines 5561 5606 +45
Branches 853 875 +22
==========================================
+ Hits 4619 4648 +29
- Misses 711 716 +5
- Partials 231 242 +11
Continue to review full report at Codecov.
|
AArnott
commented
Aug 4, 2017
| @@ -182,32 +178,9 @@ public static MemberInfo Resolve(this MemberRef memberRef) | |||
| throw new NotSupportedException(); | |||
| } | |||
|
|
|||
| [Obsolete("Use " + nameof(MemberRef) + " instead.", error: true)] | |||
| public static MemberInfo Resolve(this MemberDesc memberDesc) | |||
There was a problem hiding this comment.
This method was always just broken. And we never used it. So rather than fix it (which would require a breaking change), since it was never used I just scrape out its implementation. I'll remove these broken and unused types in v16.
AlexEyler
approved these changes
Aug 4, 2017
AArnott
added a commit
that referenced
this pull request
Jun 7, 2022
AArnott
added a commit
that referenced
this pull request
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cache the result of reflection at a few easy places.
More can certainly be done here and will be included in subsequent PRs.
I also take the opportunity to fix Equals and GetHashCode methods in light of the dual mode (metadata token vs. actual Reflection info object).