Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[google-cloud-cpp] Upgrade to v0.17.0 #9576

Merged
merged 2 commits into from
Jan 10, 2020
Merged

[google-cloud-cpp] Upgrade to v0.17.0 #9576

merged 2 commits into from
Jan 10, 2020

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jan 7, 2020 •
edited
Loading

Upgrade google-cloud-cpp to the (just released) v0.17.0

@PhoebeHui PhoebeHui self-assigned this Jan 8, 2020
PhoebeHui
PhoebeHui approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@PhoebeHui
Copy link
Contributor

/azp run

@PhoebeHui PhoebeHui marked this pull request as ready for review January 9, 2020 04:10
@PhoebeHui
Copy link
Contributor

/azp run

@coryan
Copy link
Contributor Author

coryan commented Jan 9, 2020

@PhoebeHui the OSX breakage seems unrelated. Would it help if I rebased to the latest master?

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jan 10, 2020
@PhoebeHui
Copy link
Contributor

@coryan, PR #9600 will fix the failures on OSX, it's not related to your changes. Please ignore it.

@dan-shaw dan-shaw merged commit 314d592 into microsoft:master Jan 10, 2020
@coryan coryan deleted the upgrade-google-cloud-cpp-v0.17.0 branch January 10, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coryan @PhoebeHui @dan-shaw