Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcpkg_replace_strings: new function #39998

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

vcpkg_replace_strings: new function #39998

wants to merge 1 commit into from

Conversation

autoantwort
Copy link
Contributor

#32329 (comment) Tests are coming

@MonicaLiu0311 MonicaLiu0311 added the requires:testing Needs tests added before merging label Jul 22, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Jul 23, 2024 •
edited

I think this was more attractive before vcpkg_replace_string learned to handle REGEX.
Having a very different interface with just one extra letter in the function name is not so great. Maybe it would be more convincing as part of a proper keyword interface to vcpkg_replace_string.

And tests could be a great synopsis. I would prefer to see how it is meant to be used, not how it is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
requires:testing Needs tests added before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@autoantwort @dg0yt @MonicaLiu0311