Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cppgraphqlgen] Fix build error under linux #39982

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

jimwang118
Copy link
Contributor

Fixed the following error via upstream PR.

/usr/include/c++/13/bits/unique_ptr.h:99:9: error: ‘void operator delete(void*, std::size_t)’ called on unallocated object ‘<anonymous>’ [-Werror=free-nonheap-object]
   99 |         delete __ptr;
      |         ^~~~~~~~~~~~
/root/vcpkg/buildtrees/cppgraphqlgen/src/v4.5.5-147cf636ad.clean/src/GraphQLResponse.cpp: In constructor ‘graphql::response::Value::Value(graphql::response::Type)’:
/root/vcpkg/buildtrees/cppgraphqlgen/src/v4.5.5-147cf636ad.clean/src/GraphQLResponse.cpp:931:47: note: declared here
  931 |                         _data = { EnumData {} };
      |                                               ^
cc1plus: all warnings being treated as errors
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

All features passed with following triplets:

x64-windows
x64-linux

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 19, 2024
WangWeiLin-MV
WangWeiLin-MV previously approved these changes Jul 19, 2024
@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Jul 19, 2024
@jimwang118 jimwang118 marked this pull request as ready for review July 19, 2024 10:51
@JavierMatosD
Copy link
Contributor

If this is an upstream patch, please download and apply the patch rather than checking it in.

@JavierMatosD JavierMatosD marked this pull request as draft July 20, 2024 18:28
@data-queue
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jimwang118 jimwang118 marked this pull request as ready for review July 23, 2024 02:06
@@ -1,9 +1,17 @@
vcpkg_download_distfile(LINUX_PATCH
URLS https://github.com/microsoft/cppgraphqlgen/pull/305.patch?full_index=1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a URL that references the commit id since this PR was merged? I think it is more stable

@data-queue data-queue marked this pull request as draft July 23, 2024 05:38
@data-queue data-queue marked this pull request as ready for review July 24, 2024 00:47
@data-queue data-queue merged commit cf17599 into microsoft:master Jul 24, 2024
16 checks passed
@jimwang118 jimwang118 deleted the fix-cppgraphqlgen branch July 24, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants