Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] fix find_library suffix/prefix definitions for iOS #39972

Merged

Conversation

derekcyruschow-catapult
Copy link
Contributor

For example, when building dynamic iOS libs for mp3lame, the generated mp3lame-config.cmake would be erroneously looking for libmp3lame.a instead of libmp3lame.dylib.

@dg0yt
Copy link
Contributor

dg0yt commented Jul 18, 2024

The change is okay IMO. But do you expect this to fix an immediate problem? Sane ports shouldn't depend on this anyways. (It is for portfile script mode. Project mode gets a regular CMake toolchain setup, and so mp3lame-config.cmake will work as expected.)

@derekcyruschow-catapult
Copy link
Contributor Author

derekcyruschow-catapult commented Jul 18, 2024

Project mode

The issue I saw was due to a app I have using a vcpkg manifest dependency on mp3lame, which was built via setting the CMake toolchain to use the vcpkg toolchain (<vcpkg-root>/scripts/buildsystems/vcpkg.cmake)...

  • this then creates mp3lame-config.cmake;
  • which presumably is done in script mode before project mode kicks in to build the app?

https://learn.microsoft.com/en-us/vcpkg/contributing/maintainer-guide

While portfile.cmake's and CMakeLists.txt's share a common syntax and core CMake language constructs (aka "Scripting Commands"), portfiles run in "Script Mode"

@Cheney-W Cheney-W added the category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly label Jul 19, 2024
@data-queue data-queue added the info:reviewed Pull Request changes follow basic guidelines label Jul 24, 2024
@data-queue data-queue marked this pull request as ready for review July 24, 2024 18:02
@data-queue data-queue merged commit 8babf36 into microsoft:master Jul 27, 2024
16 checks passed
@derekcyruschow-catapult derekcyruschow-catapult deleted the fix_find_library_suffixes_prefixes branch July 29, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants