utils/uf2conv.py: Fix padding with Python3 #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproduce with:
```
echo -n foo12345679 > foo
echo -n bar12345679 > bar
./utils/uf2conv.py foo -c -b 0x100 -o foo.uf2
./utils/uf2conv.py bar -c -b 0x1000 -o bar.uf2
cat foo.uf2 bar.uf2 > combined.uf2
./utils/uf2conv.py -i combined.uf2
```
Would fail like this
```
--- UF2 File Header Info ---
All block flag values consistent, 0x0000
----------------------------
Traceback (most recent call last):
File "/home/zoid/clone/uf2/./utils/uf2conv.py", line 360, in <module>
main()
File "/home/zoid/clone/uf2/./utils/uf2conv.py", line 328, in main
convert_from_uf2(inpbuf)
File "/home/zoid/clone/uf2/./utils/uf2conv.py", line 109, in convert_from_uf2
return b"".join(outp)
TypeError: sequence item 1: expected a bytes-like object, int found
```
Signed-off-by: Daniel Schaefer <[email protected]>
JohnAZoidberg
added a commit
to FrameworkComputer/qmk_firmware
that referenced
this pull request
Jan 16, 2023
See: microsoft/uf2#71 Signed-off-by: Daniel Schaefer <[email protected]>
|
I did a large refactor of this code here as well: #42 (comment). |
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce with:
Would fail like this