Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more ConsoleBench tests #17441

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Add more ConsoleBench tests #17441

merged 1 commit into from
Jun 22, 2024

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Jun 18, 2024

This now covers all major Console APIs.
In the future we could add tests that cover VT sequences as well.

@lhecker
Copy link
Member Author

lhecker commented Jun 18, 2024

I've scraped every major conhost version since Windows 8.1 from our internal build shares and tested it using this new tool. Here's the resulting measurements.html

You can find a mapping between build numbers and versions here: https://en.wikipedia.org/wiki/List_of_Microsoft_Windows_versions

Before anyone asks, the results for 10586 (Windows 10 version 1511) are not a fluke. 😅 I think that version may have had a faulty circular (text) buffer implementation. I found that there's a perfectly linear relationship between how many rows the text buffer has and how long write operations take.

The good news is that 26000 is faster across pretty much every single metric. The bad news is that some parts still aren't as fast as they used to be. But we'll get there soon enough, I'm sure. 🙂

@lhecker lhecker added the Area-Performance Performance-related issue label Jun 19, 2024
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partially blind sign - ConsoleBench is test code

@DHowett DHowett enabled auto-merge June 20, 2024 18:32
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is test code

@DHowett DHowett added this pull request to the merge queue Jun 22, 2024
Merged via the queue into main with commit bb4981c Jun 22, 2024
28 of 29 checks passed
@DHowett DHowett deleted the dev/lhecker/consolebench branch June 22, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Performance Performance-related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants