Better Warnings for Custom Pixel Shader Compilation Failures #17435
Labels
Issue-Feature
Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Needs-Tag-Fix
Doesn't match tag requirements
Needs-Triage
It's a new issue that the core contributor team needs to triage at the next triage meeting
Description of the new feature/enhancement
Right now, when D3DCompileFromFile fails, a warning is displayed that says "Unable to compile the specified pixel shader." To make it easier to debug custom shader files, it would be helpful to see the exact error message from the compiler.
![original](https://private-user-images.githubusercontent.com/104504393/339955151-bb3c65dc-d241-4918-84a6-5169eed2ad81.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUyODgwMzEsIm5iZiI6MTcyNTI4NzczMSwicGF0aCI6Ii8xMDQ1MDQzOTMvMzM5OTU1MTUxLWJiM2M2NWRjLWQyNDEtNDkxOC04NGE2LTUxNjllZWQyYWQ4MS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwOTAyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDkwMlQxNDM1MzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kMzcxNDQwMTU1YzI4NjUxNGQ2MWUzM2JjMGQ1ZTYwMWUyNGI2MDFlN2MyNjg4YzNmZmJlMmJkOWY4Y2EyZjA1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.tee5SaeGqwFPGM7BmiLaT4Jqo_-qvcmfGnV6ieVCqjc)
Current Warning:
Proposed technical implementation details
Error Type | Expected Outcome
Compile Time Error | Warning window with the exact error message from compiler
File not Found | Warning window with file not found + location of file as seen in settings.json
Path not Found | Similar behaviour
I will be creating a pull request shortly.
The text was updated successfully, but these errors were encountered: