Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priavte/noa/pr/19/updates #27

Merged
merged 4 commits into from
Mar 29, 2022
Merged

Priavte/noa/pr/19/updates #27

merged 4 commits into from
Mar 29, 2022

Conversation

noafru
Copy link
Contributor

@noafru noafru commented Mar 29, 2022

merging some changes from PR #19 with adjustments to the current main branch

danielcshn and others added 4 commits March 19, 2022 23:48
add close ssh client (main.py)
change ssh port required to default ssh port 22 (main.py)
change The Mikrotik version to RouterOS version (version.py)
add example default port ssh (README.md)
change ip 1.2.3.4 to default mikrotik ip 192.168.88.1 in executing examples (README.md)
change The tested Mikrotik SSH port of Must to Optional in the arguments (README.md)
tested in RouterOS v6.49.5 (stable) and v7.1.3 (stable)
commit df8148b
Author: noafru <[email protected]>
Date:   Tue Mar 29 13:33:26 2022 +0300

    Priavte/noa/pr/8/updates (#26)

    * Slight optimization when getting version, add concise argument - prints only suspicious and recommended items

    * Update README

    * pr8 branch with some changes

    * merge with main

    Co-authored-by: Iavor Todorov <[email protected]>

commit 61559dd
Author: noafru <[email protected]>
Date:   Tue Mar 29 11:41:56 2022 +0300

    update note

commit 83e0ae9
Merge: 9ef15fc 055b9f1
Author: noafru <[email protected]>
Date:   Mon Mar 28 15:04:24 2022 +0300

    Merge pull request #6 from jithinsarath/main

    Update README.md for typos

commit 9ef15fc
Merge: 9a834d3 cea9232
Author: noafru <[email protected]>
Date:   Mon Mar 28 14:39:36 2022 +0300

    Merge pull request #24 from microsoft/private/noa/ttl&exceptions

    fix ttl, fix paramiko params and add try-except

commit cea9232
Author: noafru <[email protected]>
Date:   Mon Mar 28 14:38:39 2022 +0300

    fix ttl, fix paramiko params and add try-except

commit 055b9f1
Author: jithinsarath <[email protected]>
Date:   Fri Mar 18 00:00:02 2022 +0530

    Update README.md for typos

    The commit fixes typos in the readme.md file
commit 81e72a0
Author: noafru <[email protected]>
Date:   Tue Mar 29 16:09:46 2022 +0300

    Update README.md

commit 5af831b
Author: noafru <[email protected]>
Date:   Tue Mar 29 16:09:04 2022 +0300

    Update README.md

commit df8148b
Author: noafru <[email protected]>
Date:   Tue Mar 29 13:33:26 2022 +0300

    Priavte/noa/pr/8/updates (#26)

    * Slight optimization when getting version, add concise argument - prints only suspicious and recommended items

    * Update README

    * pr8 branch with some changes

    * merge with main

    Co-authored-by: Iavor Todorov <[email protected]>

commit 61559dd
Author: noafru <[email protected]>
Date:   Tue Mar 29 11:41:56 2022 +0300

    update note

commit 83e0ae9
Merge: 9ef15fc 055b9f1
Author: noafru <[email protected]>
Date:   Mon Mar 28 15:04:24 2022 +0300

    Merge pull request #6 from jithinsarath/main

    Update README.md for typos

commit 9ef15fc
Merge: 9a834d3 cea9232
Author: noafru <[email protected]>
Date:   Mon Mar 28 14:39:36 2022 +0300

    Merge pull request #24 from microsoft/private/noa/ttl&exceptions

    fix ttl, fix paramiko params and add try-except

commit cea9232
Author: noafru <[email protected]>
Date:   Mon Mar 28 14:38:39 2022 +0300

    fix ttl, fix paramiko params and add try-except

commit 055b9f1
Author: jithinsarath <[email protected]>
Date:   Fri Mar 18 00:00:02 2022 +0530

    Update README.md for typos

    The commit fixes typos in the readme.md file
@noafru noafru marked this pull request as ready for review March 29, 2022 13:22
@noafru noafru merged commit dd4f962 into main Mar 29, 2022
@noafru noafru mentioned this pull request Mar 29, 2022
@noafru noafru deleted the priavte/noa/pr/19/updates branch March 29, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants