Auto format fixes #2520
Merged
Auto format fixes #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
requested review from
flyingbee2012,
BryanValverdeU,
JiuqingSong,
ianeli1,
vinguyen12 and
Andres-CT98
JiuqingSong
reviewed
Mar 21, 2024
| private handleEditorInputEvent(editor: IEditor, event: EditorInputEvent) { | ||
| const rawEvent = event.rawEvent; | ||
| if (rawEvent.inputType === 'insertText') { | ||
| const { autoBullet, autoNumbering } = this.options; |
There was a problem hiding this comment.
Move this line down, only do this when you need it
| private handleKeyDownEvent(editor: IEditor, event: KeyDownEvent) { | ||
| const rawEvent = event.rawEvent; | ||
| if (!rawEvent.defaultPrevented && !event.handledByEditFeature) { | ||
| const { autoBullet, autoNumbering, autoUnlink, autoLink } = this.options; | ||
| const { autoUnlink, autoLink } = this.options; |
Comment on lines
55
to
73
| const listItem = getFirstSelectedListItem(model); | ||
| if (listItem) { | ||
| const listItems = findListItemsInSameThread(model, listItem); | ||
| const levelIndex = listItem.levels.length - 1; | ||
| // If the index < 1, it is a new list, so it will be starting by 1, then no need to set startNumber | ||
| if (index && index > 1 && isOrderedList) { | ||
| const level = listItem?.levels[levelIndex]; | ||
| if (level) { | ||
| level.format.startNumberOverride = index; | ||
| } | ||
| } | ||
|
|
||
| listItems.forEach(listItem => { | ||
| const level = listItem.levels[levelIndex]; | ||
| if (level) { | ||
| updateListMetadata(level, metadata => | ||
| Object.assign( | ||
| {}, | ||
| metadata, |
There was a problem hiding this comment.
Are these code copied from the format API? Can we try not duplicate the code?
There was a problem hiding this comment.
I split in two apis
JiuqingSong
approved these changes
Mar 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the followings fixes:
keyboardListTriggerfunction, then AutoFormatSettings plugin from OWA can recognize a list was triggered.