Fixed typos and improved uniformity of RNW CLI command help text #13386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlenecota
reviewed
Jun 25, 2024
packages/@react-native-windows/cli/src/commands/runWindows/runWindowsOptions.ts
Outdated
Show resolved
Hide resolved
marlenecota
reviewed
Jun 25, 2024
marlenecota
reviewed
Jun 25, 2024
marlenecota
reviewed
Jun 25, 2024
marlenecota
reviewed
Jun 25, 2024
marlenecota
reviewed
Jun 25, 2024
| | `--logging` | boolean | Verbose output logging | | ||
| | `--template` | string | Specify the template to use | | ||
| | `--name` | string | The native project name. Defaults to the name property in `app.json` or `package.json` | | ||
| | `--namespace` | string | The native project namespace, expressed using dots as separators, i.e. 'Level1.Level2.Level3'. Defaults to the same as name | |
There was a problem hiding this comment.
Suggested change
| | `--namespace` | string | The native project namespace, expressed using dots as separators, i.e. 'Level1.Level2.Level3'. Defaults to the same as name | | |
| | `--namespace` | string | The native project namespace expressed using dots as separators, i.e. 'Level1.Level2.Level3'. Defaults to the same as name | |
marlenecota
reviewed
Jun 25, 2024
| | Option | Input Type | Description | | ||
| |-----------------------|------------|--------------------------------------------------| | ||
| | `--release` | boolean | Specifies a Release build | | ||
| | `--root` | string | Override the root directory for the windows build which contains the windows folder (default: `E:\\test63`) | |
There was a problem hiding this comment.
Suggested change
| | `--root` | string | Override the root directory for the windows build which contains the windows folder (default: `E:\\test63`) | | |
| | `--root` | string | Override the root directory for the Windows build which contains the windows folder (default: `E:\\test63`) | |
marlenecota
reviewed
Jun 25, 2024
marlenecota
reviewed
Jun 25, 2024
marlenecota
reviewed
Jun 25, 2024
packages/@react-native-windows/cli/src/commands/initWindows/initWindowsOptions.ts
Outdated
Show resolved
Hide resolved
marlenecota
reviewed
Jun 25, 2024
| }, | ||
| { | ||
| name: '--root [string]', | ||
| description: | ||
| 'Override the root directory for the windows build which contains the windows folder.', | ||
| 'Override the root directory for the windows build which contains the windows folder', |
There was a problem hiding this comment.
Suggested change
| 'Override the root directory for the windows build which contains the windows folder', | |
| 'Override the root directory for the Windows build which contains the windows folder', |
jonthysell
commented
Jun 25, 2024
packages/@react-native-windows/cli/src/commands/runWindows/runWindowsOptions.ts
Outdated
Show resolved
Hide resolved
jonthysell
commented
Jun 25, 2024
Thanks Marlene! Co-authored-by: Marlene Cota <[email protected]>
marlenecota
approved these changes
Jun 25, 2024
marlenecota
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some typos in the help for RNW CLI commands.
Type of Change
Why
To clarify the CLI command options.
What
See above.
Screenshots
N/A
Testing
Nothing functional was changed.
Changelog
Should this change be included in the release notes: yes
Fixed typos and improved uniformity of RNW CLI command help text
Microsoft Reviewers: Open in CodeFlow