Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SampleAppFabric to use ReactNativeAppBuilder #13382

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update SampleAppFabric to use ReactNativeAppBuilder #13382

wants to merge 3 commits into from

Conversation

sharath2727
Copy link
Contributor

@sharath2727 sharath2727 commented Jun 25, 2024 •
edited
Loading

Description

What

Update the sample-app-fabric to use ReactNativeAppBuilder

Resolves #13388

Changelog

no_

Microsoft Reviewers: Open in CodeFlow

@sharath2727 sharath2727 requested a review from a team as a code owner June 25, 2024 20:29
@sharath2727 sharath2727 self-assigned this Jun 25, 2024
jonthysell
jonthysell approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@jonthysell jonthysell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but remember if we eventually want to push the builder into 0.75 for easier testing, we'll have to backport every PR. As it stands, 0.75 is going to get a pretty empty app builder type when it snaps for the 0.75 preview.

packages/sample-app-fabric/windows/SampleAppFabric/SampleAppFabric.cpp
@@ -102,10 +62,27 @@ _Use_decl_annotations_ int CALLBACK WinMain(HINSTANCE instance, HINSTANCE, PSTR
auto hwnd = winrt::Microsoft::UI::GetWindowFromWindowId(window.Id());
auto scaleFactor = ScaleFactor(hwnd);

auto host = CreateReactNativeHost(hwnd, compositor);
auto reactInstanceSettingsBuilder{winrt::Microsoft::ReactNative::ReactInstanceSettingsBuilder()
.JavaScriptBundleFile(L"index")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please retain the #if _DEBUG and #if BUNDLE macros when setting the intial settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonthysell jonthysell jonthysell approved these changes

@acoates-ms acoates-ms Awaiting requested review from acoates-ms

Assignees

@sharath2727 sharath2727

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update sample-app-fabric to use ReactNativeAppBuilder
2 participants
@sharath2727 @jonthysell