Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Switch Component Accessible By Default #13341

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

chiaramooney
Copy link
Contributor

@chiaramooney chiaramooney commented Jun 12, 2024

Description

Type of Change

  • New Feature

Why

Make Switch control accessible by default. In Andrew's PR a few months ago (#12146) he added behavior to the JS for the Switch control to make the control accessible by default. This PR also adds the same behavior for the accessible prop, so that Switch controls are by default a part of the content UIA tree.

Resolves #11857

Testing

Tested in Playground. Switch tests have yet to be added for Fabric because Switch controls were not a part of the accessibility tree by default. Will add switch tests in full after this PR is merged.

Changelog

Should this change be included in the release notes: No

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

@TatianaKapos TatianaKapos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chiaramooney chiaramooney merged commit 0e276da into microsoft:main Jun 21, 2024
57 checks passed
@chiaramooney chiaramooney deleted the cm-switch branch June 21, 2024 17:38
@jonthysell jonthysell added Area: Fabric Support Facebook Fabric Area: Paper Parity: React Native RNW does not look or behave like upstream RN platforms labels Jul 15, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Old Architecture Broad category for issues that apply to the RN "old" architecture of Cxx Modules + Paper labels Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Accessibility Area: Fabric Support Facebook Fabric Area: Paper Area: Switch New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Old Architecture Broad category for issues that apply to the RN "old" architecture of Cxx Modules + Paper Parity: React Native RNW does not look or behave like upstream RN platforms
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Switches on Fabric should be Accessible and Focusable by Default
5 participants