Update Desktop NUSPEC to use ARM64EC #13335
Open
+34
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmoroz
approved these changes
Jun 11, 2024
dannyvv
approved these changes
Jun 11, 2024
jeffstall
suggested changes
Jun 21, 2024
| @@ -492,13 +492,13 @@ extends: | |||
| configuration: Release | |||
| - platform: x86 | |||
| configuration: Release | |||
| - platform: ARM64 | |||
| - platform: ARM64EC | |||
There was a problem hiding this comment.
I think we need to have both ARM64 and ARM64EC builds. We can't replace one with the other. There's usage cases for both. Can you please update?
microsoft-github-policy-service
bot
added
the
Needs: Author Feedback
microsoft-github-policy-service
bot
added
the
no-recent-activity
|
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ARM64EC platform to Desktop NuGet.
Type of Change
Why
Currently the Desktop NUSPEC
OfficeReact.Win32.nuspecexpects source and target paths for ARM64.What
Change the NUSPEC entries from
ARM64toARM64EC.Microsoft Reviewers: Open in CodeFlow