Gulp, TypeScript, and Monaco #6523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darzu
reviewed
Feb 4, 2020
| @@ -0,0 +1,557 @@ | |||
| const fs = require("fs"); | |||
There was a problem hiding this comment.
FWIW, gulp seems to support .ts pretty easily: "For TypeScript, rename to gulpfile.ts and install the ts-node module." https://gulpjs.com/docs/en/getting-started/javascript-and-gulpfiles
darzu
reviewed
Feb 4, 2020
| runUglify | ||
| ); | ||
|
|
||
| const travis = gulp.series(buildAll, lint, testAll, targetjs, pxtTravis); |
darzu
reviewed
Feb 4, 2020
darzu
reviewed
Feb 4, 2020
darzu
approved these changes
Feb 4, 2020
|
Very excited about gulp. It's a much better foundation. |
jwunderl
approved these changes
Feb 4, 2020
Co-Authored-By: Daryl Zuniga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things:
It also removes our dependency on pxt-monaco-typescript and replaces it with the stock TS language service. The plan is to remove that service and switch entirely over to one implemented by us in the near future.
I'm marking this as a draft PR until I've opened PRs on each of the targets to upgrade to the new TS version.