chore: Update webpage name validation check #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyaginidhi
approved these changes
Jun 14, 2024
amitjoshi438
requested review from
tyaginidhi
and removed request for
tyaginidhi
gshivi
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 4129180: [Vscode Desktop]: PAC breaks, when we add a webpage to the portal with special characters.
This pull request introduces changes to improve the validation of webpage names in the Power Pages application. The changes include a new validation rule for webpage names, updates to localization files to support the new rule, and an update to the webpage creation function to enforce the rule.
Updates to webpage name validation:
src/client/power-pages/create/Webpage.ts: Added a new regular expression test in thegetWebpageInputsfunction to ensure webpage names only contain letters, numbers, hyphens, or underscores.Localization updates:
l10n/bundle.l10n.json: Added a new localized string to inform users that webpage names should only contain letters, numbers, hyphens, or underscores.loc/translations-export/vscode-powerplatform.xlf: Added a new translation unit for the new localized string.