fix(electron): allow downloads #31390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
bugfix/electron-downloads
branch
from
ac3785c
to
e383984
Compare
mxschmitt
commented
Jun 20, 2024
This comment has been minimized.
This comment has been minimized.
Sounds good, but we'll need to skip the tests on Android. |
mxschmitt
force-pushed
the
bugfix/electron-downloads
branch
from
e383984
to
b97831f
Compare
mxschmitt
force-pushed
the
bugfix/electron-downloads
branch
from
b97831f
to
7815d5d
Compare
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"28374 passed, 648 skipped Merge workflow run. |
dgozman
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe we should move https://github.com/microsoft/playwright/blob/main/tests/library/download.spec.ts into "page tests"? Except this single test which does
browser.newPage({ acceptDownloads: false });.This was fixed by electron/electron#41718 - hence we didn't do it before. We should probably wait with this one until August 20th, when Electron v29 reaches EOL, or make this call either "not throw" / add a version check to it, since it throws in v29.
Fixes #31389
Depends on #30334