Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clock api review #31237

Merged
merged 1 commit into from
Jun 11, 2024
Merged

chore: clock api review #31237

merged 1 commit into from
Jun 11, 2024

Conversation

pavelfeldman
Copy link
Member

No description provided.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
dgozman
dgozman reviewed Jun 10, 2024
View reviewed changes
docs/src/api/class-clock.md Outdated Show resolved Hide resolved
docs/src/api/class-clock.md Outdated Show resolved Hide resolved
docs/src/api/class-clock.md Outdated Show resolved Hide resolved
docs/src/api/class-clock.md Outdated Show resolved Hide resolved
docs/src/api/class-clock.md Outdated Show resolved Hide resolved
packages/playwright-core/src/server/injected/clock.ts Outdated Show resolved Hide resolved
packages/playwright-core/src/server/injected/clock.ts Show resolved Hide resolved
packages/playwright-core/src/server/injected/clock.ts Show resolved Hide resolved
packages/playwright-core/src/server/injected/clock.ts Show resolved Hide resolved
packages/playwright-core/src/server/injected/clock.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@pavelfeldman pavelfeldman force-pushed the clock_api_3 branch 2 times, most recently from bc355f9 to ab085f0 Compare June 11, 2024 14:51
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
mxschmitt
mxschmitt reviewed Jun 11, 2024
View reviewed changes
docs/src/clock.md Outdated Show resolved Hide resolved
docs/src/clock.md Outdated Show resolved Hide resolved
docs/src/clock.md Outdated Show resolved Hide resolved
docs/src/clock.md Outdated Show resolved Hide resolved
docs/src/clock.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@pavelfeldman pavelfeldman force-pushed the clock_api_3 branch 2 times, most recently from fb47fcb to 612779d Compare June 11, 2024 15:42
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

2 flaky ⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots
⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots

28255 passed, 634 skipped
✔️✔️✔️

Merge workflow run.

@pavelfeldman pavelfeldman merged commit 6399e8d into microsoft:main Jun 11, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman left review comments

@mxschmitt mxschmitt mxschmitt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelfeldman @dgozman @mxschmitt