Copy annotation text in HTML report #30749
Conversation
This comment has been minimized.
This comment has been minimized.
amankagithub
force-pushed
the
aman/copy-annotation-text
branch
from
de107f1
to
fdd39c1
Compare
Test results for "tests 1"1 failed 2 flaky27028 passed, 610 skipped Merge workflow run. |
| display: none; | ||
| } | ||
|
|
||
| .test-case-annotation:hover .annotation-copy-button{ |
There was a problem hiding this comment.
Sounds like you would need this dance for every copy button application. Would it be possible to do something like this to encapsulate these styles:
<CopyToClipboardContainer description={description}>
<span className='annotation-copy-button'/>
</CopyToClipboardContainer>
There was a problem hiding this comment.
Not every copy button , just for this annotation copy button . We want to display the copy button only when we hover over the text . Could you please help me with how your approach would help in this use case ?
There was a problem hiding this comment.
The CopyToClipboardContainer container would position the copy button after its children and make it visible upon hover.
| return description; | ||
| } | ||
|
|
||
| function TestCaseAnnotationView({ annotation: { type, description } }: { annotation: TestCaseAnnotation }) { | ||
| return ( | ||
| <div className='test-case-annotation'> | ||
| <span style={{ fontWeight: 'bold' }}>{type}</span> | ||
| <span style={{ fontWeight: 'bold', display: 'inline-block', marginBlock: '3px' }}>{type}</span> |
There was a problem hiding this comment.
display: 'inline-block' - what else would this span be?
There was a problem hiding this comment.
By default span will be inline . I needed to add some margin to solve following problem
without-display-property.mp4
with-display-property.mp4
There was a problem hiding this comment.
I was hoping it would go away with the container approach.
|
Closing this as stale. If you still want to pursue this change, please reopen or create a new PR and link to this one. |
Feature Request : #30141
In this PR I have added changes required to make annotation text be copied in one click .
Annotation
On hover
On copy
