Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update Electron to v30 #30334

Merged
merged 2 commits into from
Jun 20, 2024
Merged

test: update Electron to v30 #30334

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f15d3e4
test: update Electron to v30
mxschmitt Jun 20, 2024
fb63029
fix
mxschmitt Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix
  • Loading branch information
@mxschmitt
mxschmitt committed Jun 20, 2024
commit fb63029367a9d7159bbcd8729f257c46d638bb5b
4 changes: 2 additions & 2 deletions tests/electron/electron-app.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,8 +315,8 @@ test('should return app name / version from manifest', async ({ launchElectronAp
});
});

test('should report downloads', async ({ launchElectronApp, server }) => {
test.skip(parseInt(require('electron/package.json').version.split('.')[0], 10) < 30, 'Depends on https://github.com/electron/electron/pull/41718');
test('should report downloads', async ({ launchElectronApp, electronMajorVersion, server }) => {
test.skip(electronMajorVersion < 30, 'Depends on https://github.com/electron/electron/pull/41718');

server.setRoute('/download', (req, res) => {
res.setHeader('Content-Type', 'application/octet-stream');
Expand Down
2 changes: 1 addition & 1 deletion tests/page/page-request-intercept.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ it('should fulfill popup main request using alias', async ({ page, server, isEle
it('request.postData is not null when fetching FormData with a Blob', {
annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/24077' }
}, async ({ server, page, browserName, isElectron, electronMajorVersion }) => {
it.skip(isElectron && electronMajorVersion < 30, 'error: Browser context management is not supported.');
it.skip(isElectron && electronMajorVersion < 31);
it.fixme(browserName === 'webkit', 'The body is empty in WebKit when intercepting');
await page.goto(server.EMPTY_PAGE);
await page.setContent(`
Expand Down
Loading