fix

microsoft · Jun 20, 2024 · fb63029 · fb63029
1 parent f15d3e4
commit fb63029
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/tests/electron/electron-app.spec.ts b/tests/electron/electron-app.spec.ts
@@ -315,8 +315,8 @@ test('should return app name / version from manifest', async ({ launchElectronAp
  });
 });
 
-test('should report downloads', async ({ launchElectronApp, server }) => {
- test.skip(parseInt(require('electron/package.json').version.split('.')[0], 10) < 30, 'Depends on https://github.com/electron/electron/pull/41718');
+test('should report downloads', async ({ launchElectronApp, electronMajorVersion, server }) => {
+ test.skip(electronMajorVersion < 30, 'Depends on https://github.com/electron/electron/pull/41718');
 
  server.setRoute('/download', (req, res) => {
  res.setHeader('Content-Type', 'application/octet-stream');

diff --git a/tests/page/page-request-intercept.spec.ts b/tests/page/page-request-intercept.spec.ts
@@ -285,7 +285,7 @@ it('should fulfill popup main request using alias', async ({ page, server, isEle
 it('request.postData is not null when fetching FormData with a Blob', {
  annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/24077' }
 }, async ({ server, page, browserName, isElectron, electronMajorVersion }) => {
- it.skip(isElectron && electronMajorVersion < 30, 'error: Browser context management is not supported.');
+ it.skip(isElectron && electronMajorVersion < 31);
  it.fixme(browserName === 'webkit', 'The body is empty in WebKit when intercepting');
  await page.goto(server.EMPTY_PAGE);
  await page.setContent(`