Add API_IMPL_* blocks around shared provider methods as they are C APIs #7908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgchen1
approved these changes
Jun 1, 2021
snnn
approved these changes
Jun 2, 2021
xzhu1900
pushed a commit
that referenced
this pull request
Jun 2, 2021
xzhu1900
added a commit
that referenced
this pull request
Jun 2, 2021
* [OpenVINO-EP] Adding OpenVINO-EP samples to Msft Repo (#7826) * Added ONNX_OV_EP samples ->Added cpp, python and csharp samples using OpenVINO Execution Provider. Signed-off-by: MaajidKhan <[email protected]> * [js/web] update README.md (#7894) * Add API_IMPL_* blocks around shared provider methods as they are C APIs (#7908) * Missing logic for cuda nuget package (#7911) Co-authored-by: Maajid khan <[email protected]> Co-authored-by: Yulong Wang <[email protected]> Co-authored-by: Ryan Hill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
If the shared libraries don't exist or throw exceptions in their initialization we should not let this be sent into the C API.