Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update spdlog to 1.12.0 #42

Merged
merged 2 commits into from
Dec 20, 2023
Merged

chore: update spdlog to 1.12.0 #42

merged 2 commits into from
Dec 20, 2023

Conversation

cplepage
Copy link
Contributor

Alpine 3.19 got rid of lfs64
https://gitlab.alpinelinux.org/alpine/aports/-/commit/cab9b787b39387f0b3d30d218b0739c3e21aefb8

So spdlog fixed by not using it in musl
gabime/spdlog@287a00d

A small spdlog update is required to install vscode in Alpine 3.19

Installing @vscode/spdlog with spdlog v1.11.0 in Alpine 3.19

10.55 npm ERR! ../deps/spdlog/include/spdlog/details/os-inl.h:241:19: error: aggregate 'spdlog::details::os::filesize(FILE*)::stat64 st' has incomplete type and cannot be defined
10.55 npm ERR!   241 |     struct stat64 st;
10.55 npm ERR!       |                   ^~
10.55 npm ERR! ../deps/spdlog/include/spdlog/details/os-inl.h:242:11: error: '::fstat64' has not been declared; did you mean 'stat64'?
10.55 npm ERR!   242 |     if (::fstat64(fd, &st) == 0)
10.55 npm ERR!       |           ^~~~~~~
10.55 npm ERR!       |           stat64

Installing @vscode/spdlog with spdlog v1.12.0 in Alpine 3.19 works like a charm!

@cplepage
Copy link
Contributor Author

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

@deepak1556 deepak1556 added this to the December / January 2024 milestone Dec 20, 2023
@deepak1556 deepak1556 self-assigned this Dec 20, 2023
@deepak1556 deepak1556 enabled auto-merge (squash) December 20, 2023 19:12
@deepak1556 deepak1556 changed the title spdlog version update chore: update spdlog to 1.12.0 Dec 20, 2023
@deepak1556 deepak1556 merged commit 4becd02 into microsoft:main Dec 20, 2023
7 checks passed
@cplepage
Copy link
Contributor Author

@deepak1556 Thanks for merging 🙏

Expected time before publishing to npmjs?

@deepak1556
Copy link
Contributor

I don't have publishing rights for this repo, /cc @rzhao271 ☝️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants