Rework TestPseudoConsolePowershell #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
force-pushed
the
rework-pty-test
branch
3 times, most recently
from
9e33c56
to
5892a85
Compare
dcantah
commented
Dec 23, 2021
| @@ -1,3 +1,6 @@ | |||
| run: | |||
| timeout: 8m | |||
There was a problem hiding this comment.
Bumped this as the linter was timing out while running. We have too much code now 😐
|
It would be nice to have a test checking that the output we get from the conpty |
|
@helsaawy Agreed, let me look into this. Do we want to merge this for the time being so we can de-flake the CI? (after review of course haha) |
That sounds good, since it may take some experimentation to see if thats possible |
anmaxvl
approved these changes
Dec 30, 2021
Before this test used to write something to the pty and then see if we could read the same thing shortly afterwards. Really all we wanna test here is just that we can write things in general, so the same thing that TestExecStdinPowershell is currently doing should suffice. If the process exits then the 'exit' write went through so that should be plenty for this test. This change additionally adds a timeout for waiting for the process to exit for TestPseudoConsolePowershell as well as TestExecStdinPowershell so we have some indicator for if the 'exit' write didn't work. Signed-off-by: Daniel Canter <[email protected]>
dcantah
force-pushed
the
rework-pty-test
branch
from
5892a85
to
42c793c
Compare
|
Needed to rebase to pull in this 0124eb3 |
dcantah
added a commit
to dcantah/hcsshim
that referenced
this pull request
Jan 4, 2022
Before this test used to write something to the pty and then see if we could read the same thing shortly afterwards. Really all we wanna test here is just that we can write things in general, so the same thing that TestExecStdinPowershell is currently doing should suffice. If the process exits then the 'exit' write went through so that should be plenty for this test. This change additionally adds a timeout for waiting for the process to exit for TestPseudoConsolePowershell as well as TestExecStdinPowershell so we have some indicator for if the 'exit' write didn't work. Signed-off-by: Daniel Canter <[email protected]> (cherry picked from commit e093fbd) Signed-off-by: Daniel Canter <[email protected]>
dcantah
added a commit
to dcantah/hcsshim
that referenced
this pull request
Jan 4, 2022
Before this test used to write something to the pty and then see if we could read the same thing shortly afterwards. Really all we wanna test here is just that we can write things in general, so the same thing that TestExecStdinPowershell is currently doing should suffice. If the process exits then the 'exit' write went through so that should be plenty for this test. This change additionally adds a timeout for waiting for the process to exit for TestPseudoConsolePowershell as well as TestExecStdinPowershell so we have some indicator for if the 'exit' write didn't work. Signed-off-by: Daniel Canter <[email protected]> (cherry picked from commit e093fbd) Signed-off-by: Daniel Canter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, this test used to write something to the pty and then see if we
could read the same thing shortly afterwards. Really all we wanna test here
is just that we can write things in general, so the same thing that
TestExecStdinPowershell is currently doing should suffice.
If the process exits then the 'exit' write went through so that should be
plenty for this test. This change additionally adds a timeout for waiting
for the process to exit for TestPseudoConsolePowershell as well as
TestExecStdinPowershell so we have an indicator for if the 'exit' write
didn't work.