Swap to the internal/exec pkg for host process containers #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change swaps to using the new internal/exec package for host process containers to make use of the pseudo console functionality and ability to launch a process in a job object at creation time instead of assigning shortly after. This does not add in the implementation for pseudo console usage, just changes to the package that allows the functionality. Signed-off-by: Daniel Canter <[email protected]>
This change adds in the necessary bits to get tty support for host process containers working by leveraging the pseudo console APIs in Windows and the new internal/exec package. Signed-off-by: Daniel Canter <[email protected]>
dcantah
commented
Dec 20, 2021
|
fyi @jsturtevant @marosset as you'll be happy haha |
anmaxvl
approved these changes
Dec 20, 2021
|
overall, lgtm 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change swaps to using the new internal/exec package for host process containers to make use of the pseudo console functionality and ability to launch a process in a job object at creation time instead of assigning shortly after. This PR additionally adds in the bits needed to get tty support for host process up and running. See below for it in action:
hpctty.mp4