Add endpoint settings to add nic call #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kathryn Baldauf <[email protected]>
helsaawy
reviewed
Dec 17, 2021
helsaawy
reviewed
Dec 17, 2021
dcantah
reviewed
Dec 23, 2021
Signed-off-by: Kathryn Baldauf <[email protected]>
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to pass in endpoint settings as part of a call to
AddNICin ncproxy. Typically, a call to create an endpoint is made before the UVM is up and therefore we cannot query the UVM for information to assist in setting the correct iov policy values. However, at the time of calling AddNIC we know that the UVM is up. The purpose of this PR is to allow the caller to set iov policy after the endpoint has been created but before adding a nic to the UVM.Signed-off-by: Kathryn Baldauf [email protected]