Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReadExt4SuperBlock function #1229

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Nov 16, 2021

Previously the function would read bytes from a given file
and convert them into internal ext4 super block object,
without checking that the read bytes are actually ext4
super block.
Fix the behavior by checking ext4 super block magic.

Signed-off-by: Maksim An [email protected]

Previously the function would read bytes from a given file
and convert them into internal ext4 super block object,
without checking that the read bytes are actually ext4
super block.
Fix the behavior by checking ext4 super block magic.

Signed-off-by: Maksim An <[email protected]>
@anmaxvl anmaxvl requested a review from a team as a code owner November 16, 2021 17:23
ext4/tar2ext4/tar2ext4.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion

@dcantah dcantah self-assigned this Nov 16, 2021
Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm again

Copy link
Contributor

@ambarve ambarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anmaxvl anmaxvl merged commit f52c346 into microsoft:master Nov 23, 2021
@anmaxvl anmaxvl deleted the fix-read-ext4-superblock branch November 23, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants