Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework merkle tree implementation to use io.Reader instead of byte array #1209

Merged
merged 4 commits into from
Nov 11, 2021
Merged

Rework merkle tree implementation to use io.Reader instead of byte array #1209

merged 4 commits into from
Nov 11, 2021

Commits on Nov 9, 2021

  1. Rework merkle tree implementation to use io.Reader instead of byte array 

    MerkleTree implementation requires the entire content of ext4 file
system to be read into a byte array when computing cryptographic digest.

This PR reworks the existing implementation to work with io.Reader
interface instead.

Additionally update the existing usages of MerkleTree with the new
MerkleTreeWithReader implementation.

Signed-off-by: Maksim An <[email protected]>
    @anmaxvl
    anmaxvl committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    a31c505 View commit details
    Browse the repository at this point in the history

  2. pr feedback: use bufio.Reader, Read vs io.ReadFull, renaming 

    Signed-off-by: Maksim An <[email protected]>
    @anmaxvl
    anmaxvl committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    6870731 View commit details
    Browse the repository at this point in the history

  3. pr feedback: add ConvertTarToExt4 

    Separate tar to ext4 logic of Convert into a ConvertTarToExt4
function.

Signed-off-by: Maksim An <[email protected]>
    @anmaxvl
    anmaxvl committed Nov 9, 2021
    Configuration menu
    Copy the full SHA
    90aa8cf View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. pr feedback: switch from bufio.Reader to io.Reader 

    Signed-off-by: Maksim An <[email protected]>
    @anmaxvl
    anmaxvl committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    a02bdf5 View commit details
    Browse the repository at this point in the history