Enable scratch space encryption via annotation #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SeanTAllen and @AntonioND PTAL as well. |
AntonioND
reviewed
Aug 9, 2021
test/vendor/github.com/Microsoft/hcsshim/pkg/securitypolicy/securitypolicyenforcer.go
Outdated
Show resolved
Hide resolved
|
what does "PTAL" mean? |
|
@SeanTAllen PTAL = Please take a look |
|
I gave @anmaxvl a couple bits of feedback synchronously. |
04fd87e
to
fc1b62e
Compare
|
Looks good to me. |
|
@anmaxvl My PR would take a millennium to get in/review and needs to be rebased also :/ |
dcantah
reviewed
Aug 20, 2021
dcantah
reviewed
Aug 20, 2021
|
I'm always shocked at the amount of places we need to change just to add one field lol |
that's unfortunate |
dcantah
reviewed
Aug 24, 2021
386d8c9
to
100caec
Compare
dcantah
approved these changes
Sep 8, 2021
|
This needs a rebase now 🥲. @msscotb Do you have some time to check this (realized you're assigned here). |
Add bool annotation "io.microsoft.virtualmachine.storage.scratch.encrypted" that enables scratch space encryption. Update guest request protocols to allow encryption for SCSI devices. Signed-off-by: Maksim An <[email protected]>
Signed-off-by: Maksim An <[email protected]>
Signed-off-by: Maksim An <[email protected]>
8f34552
to
ba95f60
Compare
msscotb
approved these changes
Sep 15, 2021
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Nov 17, 2021
Related work items: microsoft#1062, microsoft#1087, microsoft#1089, microsoft#1095, microsoft#1104, microsoft#1112, microsoft#1117, microsoft#1118, microsoft#1125, microsoft#1137, microsoft#1139, microsoft#1140, microsoft#1141, microsoft#1142, microsoft#1143, microsoft#1145, microsoft#1146, microsoft#1150, microsoft#1151, microsoft#1153, microsoft#1154, microsoft#1155, microsoft#1156, microsoft#1157, microsoft#1158, microsoft#1159, microsoft#1161, microsoft#1162, microsoft#1163, microsoft#1164, microsoft#1165, microsoft#1166, microsoft#1167, microsoft#1168, microsoft#1169, microsoft#1171, microsoft#1172, microsoft#1173, microsoft#1174, microsoft#1178
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Add bool annotation "io.microsoft.virtualmachine.storage.scratch.encrypted" that enables scratch space encryption. Update guest request protocols to allow encryption for SCSI devices. Signed-off-by: Maksim An <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bool annotation "io.microsoft.virtualmachine.storage.scratch.encrypted"
that enables scratch space encryption.
Update guest request protocols to allow encryption for SCSI
devices.
Signed-off-by: Maksim An [email protected]