-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable scratch space encryption via annotation #1095
Enable scratch space encryption via annotation #1095
Conversation
@SeanTAllen and @AntonioND PTAL as well. |
test/vendor/github.com/Microsoft/hcsshim/pkg/securitypolicy/securitypolicyenforcer.go
Outdated
Show resolved
Hide resolved
what does "PTAL" mean? |
@SeanTAllen PTAL = Please take a look |
I gave @anmaxvl a couple bits of feedback synchronously. |
04fd87e
to
fc1b62e
Compare
Looks good to me. |
@anmaxvl My PR would take a millennium to get in/review and needs to be rebased also :/ |
I'm always shocked at the amount of places we need to change just to add one field lol |
that's unfortunate |
386d8c9
to
100caec
Compare
This needs a rebase now 🥲. @msscotb Do you have some time to check this (realized you're assigned here). |
Add bool annotation "io.microsoft.virtualmachine.storage.scratch.encrypted" that enables scratch space encryption. Update guest request protocols to allow encryption for SCSI devices. Signed-off-by: Maksim An <[email protected]>
Signed-off-by: Maksim An <[email protected]>
Signed-off-by: Maksim An <[email protected]>
8f34552
to
ba95f60
Compare
Related work items: microsoft#1062, microsoft#1087, microsoft#1089, microsoft#1095, microsoft#1104, microsoft#1112, microsoft#1117, microsoft#1118, microsoft#1125, microsoft#1137, microsoft#1139, microsoft#1140, microsoft#1141, microsoft#1142, microsoft#1143, microsoft#1145, microsoft#1146, microsoft#1150, microsoft#1151, microsoft#1153, microsoft#1154, microsoft#1155, microsoft#1156, microsoft#1157, microsoft#1158, microsoft#1159, microsoft#1161, microsoft#1162, microsoft#1163, microsoft#1164, microsoft#1165, microsoft#1166, microsoft#1167, microsoft#1168, microsoft#1169, microsoft#1171, microsoft#1172, microsoft#1173, microsoft#1174, microsoft#1178
Add bool annotation "io.microsoft.virtualmachine.storage.scratch.encrypted" that enables scratch space encryption. Update guest request protocols to allow encryption for SCSI devices. Signed-off-by: Maksim An <[email protected]>
Add bool annotation "io.microsoft.virtualmachine.storage.scratch.encrypted"
that enables scratch space encryption.
Update guest request protocols to allow encryption for SCSI
devices.
Signed-off-by: Maksim An [email protected]