Improve wording in CONTRIBUTING.md #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #2
|
@richlander Does this look good to you? |
|
Looks good, but would still be good to get clarity on the guidance. Is the guidance to create a branch to isolate changes from the fork's master? I'd like clarity of the source of guidance. Your change looks good in the face of the guidance. |
|
There definitely needs to be some more guidance on how to get a request accepted. In particular the requirements around compat and passing all existing tests. |
|
We still need to improve the doc on policy. This change looks good. I'll merge it. |
richlander
added a commit
that referenced
this pull request
Oct 28, 2014
Improve wording in CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2