Add calls to register/unregister repos #3534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f30055f.
**Summary of the pull request** This PR contains implementation changes for the File Explorer Source Control Integration experimental feature. This feature will allow File Explorer to obtain property information from source control technologies for display (image attached below): **Detailed description of the pull request / Additional comments** This PR contains the following changes: - Reference official Dev Home SDK version (that defines APIs for File Explorer Source Control Integration) - Declare FileExplorerSourceControlIntegration as an experimental feature - The FileExplorerSourceControlIntegration project which creates a COM Server used to communicate information with File Explorer - The FileExplorerGitIntegration project which allows Dev Home to come with an inbox extension that understands git - Basic Unit Tests **Validation steps performed** SDK and MSIX local builds Tested Git Integration File Explorer behavior inside VM Related work items: #48431506
…ntrol extensions inside Dev Home (#2984) * changes to write/read data (extension information + root path) from json * address PR comments * revert line endings * address PR comments
* fix * move nullable property in csproj * fix format
* declare appextension for git, find all source control extensions, UI changes, SDK changes, get extension information to use for mapping * changes to map extension to registered root paths, add validation to git implementation * changes after testing * use serilog in validation code * reorder using * use published SDK version * address PR feedback * address PR feedback * address PR feedback * Minor cleanup of RepositoryTracking.cs --------- Co-authored-by: Ryan Shepherd <[email protected]>
* basic remove UI * address feedback
* detect git and invoke functionality * address PR comments * address PR feedback * address style comments
* WARP SPEED COMMIT HISTORY. Rooted out and worked around a major bottleneck inside LibGit2Sharp * Better status * Introduce RepositoryWrapper to lock access to Repository * Update unit test to reflect new repo status * Check cache before calling Repository.IsValid
…inside Dev Home (#3484) * proposed telemetry changes for add/remove repository * remove unrequired using statements * address PR feedback * address PR feedback * adjust comment * add count of repos tracked inside Dev Home to event
… flavors in appxmanifest
ssparach
reviewed
Aug 2, 2024
| var normalizedPath = rootPath.ToUpper(CultureInfo.InvariantCulture).TrimEnd(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar); | ||
| var result = SourceControlIntegration.ValidateSourceControlExtension(extensionCLSID, normalizedPath); | ||
| var normalizedPath = rootPath.TrimEnd(Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar); | ||
| var result = SourceControlIntegration.ValidateSourceControlExtension(extensionCLSID, normalizedPath); |
There was a problem hiding this comment.
With the recent UI changes merged, these calls to register/unregister will have to be placed differently. The call to register would need to go in AssignSourceControlProviderToRepository and unregister would need to go in
RemoveTrackedRepositoryFromDevHome. Thanks!
Base automatically changed from
feature/fileexplorer-sourcecontrol-integration
to
main
August 6, 2024 19:45
dhoehna
reviewed
Aug 7, 2024
|
|
||
| public static class SourceControlIntegrationHelper | ||
| { | ||
| public static string GetSafeRootPath(string rootPath) |
There was a problem hiding this comment.
I'm not a fan of the name. This isn't returning the root path, but a part of the root path. The last part. maybe GetLowestDirectoryFromRootPath, or GetNameOfRepositoryDirectory?
There was a problem hiding this comment.
Also, I do not agree that the word "safe" is appropriate because no names are being obfuscated.
|
This is superseded by #3555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
I've strengthened the FileExplorer feature detection and put in some temporary workarounds in the helpers package so that we can now register/unregister repos directly from within DevHome.
Detailed description of the pull request / Additional comments
This is temporarily using a private version of the helpers package while I work on publishing an official version. Will update the version once available.
Also removed the upper-casing of the file paths. Might still want to consider some sort of "case correction" - Windows file system is case-insensitive, but Git is a bit less forgiving, so we should strive to use the exact case Windows and Git are actually using.
Validation steps performed
Built private build and tested the register/unregister calls.
PR checklist