Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Environments] Extension Refresh & other fixes #3532

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

huzaifa-d
Copy link
Contributor

@huzaifa-d huzaifa-d commented Aug 1, 2024

Summary of the pull request

  1. Bug fix - Fixes "Create Environments" button showing cached extension availability.
    Using the button after enabling extensions, didn't refresh the page and didn't show data from the enabled extension.
    The PR removes the caching code and refreshes the page every time navigated to.

  2. Bug fix - Fixes adding incorrect user to Hyper - V admin group.
    Adding a user to the Hyper-V admin group runs an elevated script. And getting the current user in this script returns the admin.
    The bug was that the admin was being added to the group, not the user who might have initiated the operation. The fix adds the user as a parameter to the script call.

  3. Bug fix - Hides browse button under repo manager for remote machines.
    Having a browse button, while configuring remote machines, was confusing as it browsed the local machine instead.
    The PR hides the button in cases where remote machines are being configured.

  4. Bug fix - Machine config page doesn't load extension data
    If one of the accounts associated with an extension errored out, an exception caused the rest of the data to be skipped.
    The PR removes the data with the errors from the relevant variable, since it has already been handled.

Validation steps performed

Each fix was tested manually.

PR checklist

@huzaifa-d huzaifa-d marked this pull request as ready for review August 7, 2024 17:36
@huzaifa-d huzaifa-d merged commit 2dbb9e4 into main Aug 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment