Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring winget/dsc services out of UI projects #3134

Merged
merged 43 commits into from
Jun 26, 2024

Conversation

AmelBawa-msft
Copy link
Contributor

@AmelBawa-msft AmelBawa-msft commented Jun 5, 2024

Summary of the pull request

References and relevant issues

  • Moved Windows Package Manager to a new csproj
  • Decoupled DSC from Windows Package Manager and promoted to a separate csproj
  • Rename IAppInstallManagerService to IMicrosoftStoreService
  • Rename IWindowsPackageManager to IWinGet
  • Use Microsoft.Extensions.Logging.ILogger instead of Serilog.ILogger in DevHome.Services.*
  • Restructure DSC into services instead of a single helper file
graph TB;
    %%{init:{'flowchart':{"defaultRenderer": "elk"}}}%%
    subgraph Services["\n\n\n\nService projects:\n- UI agnostic\n- Mockable\n- Reusable"]
        Core
        WPM
        DSC
    end

    Core[Core]
    WPM[WindowsPackageManager]
    DSC[DesiredStateConfiguration]
    SF[SetupFlow]
    SFE[SetupFlowElevated]
    Common[Common]
    
    WPM --> Core
    DSC --> Core
    SF --> WPM
    SF --> DSC    
    SFE --> WPM
    SFE --> DSC
    Common --> Core
Loading

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

@AmelBawa-msft AmelBawa-msft changed the title Refactoring winget services out of UI projects Refactoring winget/dsc services out of UI projects Jun 14, 2024
@krschau
Copy link
Collaborator

krschau commented Jun 21, 2024

You might want to rebase instead of merge... looks like your PR has pulled in previous changes, making it harder to see what changed here.

Copy link
Collaborator

@krschau krschau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest moving new stuff under Common in a separate change.
Also, you might want to create Debug_FailFast configs for the new projects

@AmelBawa-msft AmelBawa-msft merged commit 982f03f into main Jun 26, 2024
4 checks passed
@AmelBawa-msft AmelBawa-msft deleted the user/amelbawa/services branch June 26, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants