Machine config list navigation, and repo config names. #3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
approved these changes
Jun 4, 2024
| <TextBlock x:Name="SetupEnvironmentHeader" Style="{StaticResource SettingsSectionHeaderTextBlockStyle}" x:Uid="ms-resource:https:///DevHome.SetupFlow/Resources/MainPage_EnvironmentSetup"/> | ||
| <!-- Transparent Grid wrapper for displaying tooltip on disabled settings card --> | ||
| <Grid Background="Transparent"> | ||
| <ListView ItemContainerStyle="{ThemeResource ListViewItemStretchStyle}" SelectionMode="Single"> | ||
| <Grid Background="Transparent"> |
There was a problem hiding this comment.
Can we remove the Background, since I assume transparent by default?
There was a problem hiding this comment.
@AmelBawa-msft Is this still needed? I disabled a settings card but I didn't get any tooltip.
EricJohnson327
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
The buttons in the Machine Configuration main page could be navigated only via tabs. Not the arrow keys.
I put the items in a ListView. Now all items in the group can be navigated with the arrow keys.
The repo names in the RepoConfig page had the incorrect automation names. Fixed that.
Moved some DevDrive code over to the view model.
References and relevant issues
https://task.ms/50553376
https://task.ms/49676606
Detailed description of the pull request / Additional comments
Validation steps performed
Manually ran and tested.
For the narrator, I added repos and listened to the narrator when they were on the repo config screen.
For Dev Drive
PR checklist