Announcing removing widgets from dashboard #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krschau
reviewed
Apr 5, 2024
| @@ -329,6 +332,12 @@ private async void HandleAdaptiveAction(RenderedAdaptiveCard sender, AdaptiveAct | |||
| // https://github.com/microsoft/devhome/issues/644 | |||
| } | |||
|
|
|||
| public void AnnounceDeleted() | |||
There was a problem hiding this comment.
I know it's gross to Application.Current.GetService the ScreenReaderService in WidgetControl, but can we do this there?
krschau
approved these changes
Apr 5, 2024
AmelBawa-msft
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR adds the functionality for the narrator to say "Widget removed" whenever a widget is removed from the dashboard.
References and relevant issues
https://dev.azure.com/microsoft/OS/_workitems/edit/49357314
Detailed description of the pull request / Additional comments
When a user uses narrator and clicks, it should tell them that the action was completed. To do that, we use the screen reader service, that has a hidden text block acting as a live region on shell page.
We also changed the
LiveSettingto "Assertive" on this text block to ensure it will always have priority on the announcements. Without being "Assertive", it may not be announced in result of some new control getting focus.Validation steps performed
PR checklist