Fix HighContrast issues in Widgets and WhatsNewPage #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmelBawa-msft
approved these changes
Apr 3, 2024
| @@ -16,6 +16,7 @@ | |||
| <ResourceDictionary Source="/Styles/WindowTitleBar_ThemeResources.xaml" /> | |||
|
|
|||
| <!-- Resources from other projects --> | |||
| <ResourceDictionary Source="ms-appx:https:///DevHome.Dashboard/Styles/Dashboard_ThemeResources.xaml" /> | |||
There was a problem hiding this comment.
Thanks for continuing the pattern 🥳 I left a comment about the Environment in another PR to maintain a consistent structure.
vineeththomasalex
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Add better theme resource colors for widgets, including for HighContrast mode. Colors based on SettingsCard. More colors are included than used, in case we ever bring back clickability/hover states on widgets.
Also, use Dark version of WhatsNewPage background in high contrast mode, since it fits better.
References and relevant issues
https://microsoft.visualstudio.com/OS/_workitems/edit/49362243
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist