Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Action.ChooseFile for adaptive cards #2477

Merged
merged 17 commits into from
Jun 5, 2024

Conversation

joadoumie
Copy link
Contributor

@joadoumie joadoumie commented Mar 27, 2024

Summary of the pull request

The Action.ChooseFile adaptive card element allows a card author to launch a File Picker from Dev Home and obtain the chosen file. If no file is chosen, the "FilePath" field will be null. The author may use the action as an "inlineAction" on a Text input. The SSH Keychain widget uses the action this way.
image

This action is experimental while it goes through API review.

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

@joadoumie
Copy link
Contributor Author

@krschau - this is the starting point we can work from, still got some refactoring, UI clean up etc. to finish!

@joadoumie joadoumie mentioned this pull request Apr 3, 2024
3 tasks
@krschau krschau force-pushed the user/joadoumie/file-picker branch 3 times, most recently from 1f64109 to b383d43 Compare April 23, 2024 22:31
@krschau krschau force-pushed the user/joadoumie/file-picker branch from b383d43 to d86f2af Compare May 20, 2024 20:20
@krschau krschau force-pushed the user/joadoumie/file-picker branch from 18d0b93 to a2c75d3 Compare June 3, 2024 17:31
@krschau krschau marked this pull request as ready for review June 3, 2024 19:25
@krschau krschau changed the title feat-file-picker-renderer: First pass at adding a custom file picker … Add Action.ChooseFile for adaptive cards Jun 4, 2024
@krschau krschau requested a review from dhoehna June 4, 2024 19:57

// Parse the JSON properties of the action.
// The Verb ChooseFile is not meant to be localized.
Verb = inputJson.GetNamedString("verb", "ChooseFile"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The verb in this case is always intended to be "ChooseFile"? Should the user be able to use a different string for this verb?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should get the verb specified in the card, and if one is not specified, use the default of "ChooseFile".

@EricJohnson327 EricJohnson327 merged commit e5e1a99 into main Jun 5, 2024
4 checks passed
@EricJohnson327 EricJohnson327 deleted the user/joadoumie/file-picker branch June 5, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Widgets] SSH keychain widget requires typing in a path
4 participants